Add TODO and cleanup

velazcod · Jul 3, 2013 · 68ab371 · 68ab371
1 parent 78dd13c
commit 68ab371
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 1 deletion.
diff --git a/TODO b/TODO
@@ -0,0 +1,4 @@
+Auto scroll (forced) when coming back using scroll percentages?
+
+
+
diff --git a/...Facebook/src/main/java/com/danvelazco/fbwrapper/activity/BaseFacebookWebViewActivity.java b/...Facebook/src/main/java/com/danvelazco/fbwrapper/activity/BaseFacebookWebViewActivity.java
@@ -169,7 +169,7 @@ public void onResume() {
         registerReceiver(mConnectivityReceiver,
                 new IntentFilter(ConnectivityManager.CONNECTIVITY_ACTION));
 
-        // TODO: fix this, this is a horrible lifecycle hack...
+        // Horrible lifecycle hack
         if (mCreatingActivity) {
             mCreatingActivity = false;
             return;

diff --git a/...-for-Facebook/src/main/java/com/danvelazco/fbwrapper/webview/FacebookWebChromeClient.java b/...-for-Facebook/src/main/java/com/danvelazco/fbwrapper/webview/FacebookWebChromeClient.java
@@ -178,6 +178,10 @@ public void onShowCustomView(View view, CustomViewCallback callback) {
      */
     @Override
     public void onHideCustomView() {
+
+        // [TODO][BUG]: video player won't close sometimes, only toggle media controls
+        // [TODO][BUG]: sound from video will keep playing sometimes
+
         if (mCustomViewCallback != null) {
             // Fire the callback
             mCustomViewCallback.onCustomViewHidden();

diff --git a/Tinfoil-for-Facebook/src/main/res/values/colors.xml b/Tinfoil-for-Facebook/src/main/res/values/colors.xml
@@ -16,6 +16,7 @@
 -->
 <resources>
 
+    <color name="holo">#33b5e5</color>
     <color name="gray">#cdcdcd</color>
     <color name="light_gray">#ededed</color>
     <color name="light_gray_alt">#dddddd</color>