Skip to content
This repository has been archived by the owner on Jul 26, 2023. It is now read-only.

Testing libraries with support for jQuery 1.x #267

Open
jesperronn opened this issue Oct 16, 2015 · 2 comments
Open

Testing libraries with support for jQuery 1.x #267

jesperronn opened this issue Oct 16, 2015 · 2 comments

Comments

@jesperronn
Copy link

From 'dependencies section':

jasmine-jquery is tested with jQuery 2.0 on IE, FF, Chrome, and Safari. There is a high chance
it will work with older versions and other browsers as well, but I don't typically run test suite
against them when adding new features.

And the change that enforces it in #192: #192 (diff)

Now, for another library which runs multiple browser test, this could be a problem and affect browser support. One example project where I saw it: https://github.com/corejavascript/typeahead.js/

In Typeahead.js, the JQuery dependency is 1.7:

https://github.com/corejavascript/typeahead.js/blob/master/bower.json#L9

Is there a simple way, where projects can use bower and get the correct versions to match dependencies?

What would be the correct version of jasmine-query to match JQuery 1.7?

@jesperronn
Copy link
Author

Oh and one more thing: What about compatibility with jasmine 2 if using jasmine-query 1.7 to preserve compatibility with jquery 1?

I am not sure I can figure this out without your help 👍

@travisjeffery
Copy link
Collaborator

Hey there, jasmine-jquery 1.x works with jQuery 1.x and Jasmine 1.x. And jasmine-jquery 2.x works with jQuery 2.x and Jasmine 2.x. Adding backwards compatibility with jQuery 1.x in the current version might be possible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants