FilesCollection.findOne(null) should return null

[exKAZUu]

Although Mongo.Collection.findOne(null) always returns null, FilesCollection.findOne(null) returns a document.
I feel it's confusing, so I would propose that FilesCollection.findOne(null) should return null.

[dr-dimitru]

Agree, will add to next release
Currently it acts as FilesCollection.findOne({})

[dr-dimitru]

Hi @exKAZUu ,

This issue is solved in v1.7.3
Please update and test it on your end.

[exKAZUu]

Hi, thank you for your update!
I checked the new version and found some issues.
(Sorry. I should have mentioned about find.)

Here is the behaviour of Mongo.Collection (i.e. expected).

Collection.find({}).fetch() => an array of documents
Collection.find().fetch() => an array of documents
Collection.find(null).fetch() => an empty array
Collection.find(undefined).fetch() => an empty array

Collection.findOne({}) => a documents
Collection.findOne() => a documents
Collection.findOne(null) => undefined
Collection.findOne(undefined) => undefined

However, FilesCollection now works as follows.

Collection.find({}).fetch() => an array of documents
Collection.find().fetch() => an array of documents
Collection.find(null).fetch() => an array of documents (should be an empty array)
Collection.find(undefined).fetch() => an array of documents (should be an empty array)

Collection.findOne({}) => a document
Collection.findOne() => undefined (should be a document)
Collection.findOne(null) => undefined
Collection.findOne(undefined) => undefined

[exKAZUu]

I suspect that it is caused by the difference between JavaScript (ES2015) and CoffeeScript.
Although CoffeeScript's default values for arguments are used when the argument is null or undefined, JavaScript's default values for arguments are used when the argument is only undefined.