Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove templating and other blaze-depencenies #242

Closed
macrozone opened this issue Sep 26, 2016 · 3 comments · Fixed by #257
Closed

Remove templating and other blaze-depencenies #242

macrozone opened this issue Sep 26, 2016 · 3 comments · Fixed by #257
Labels
enhancement

Comments

@macrozone
Copy link
Contributor

macrozone commented Sep 26, 2016 •
edited
Loading

when using this package without blaze, it will bloat the bundle because it loads templating, blaze, jquery and so on.

I think it's not needed to have this depencency, can we remove it or make it optional?
@dr-dimitru
Copy link
Member

It comes with default template helper fileURL. Removing templating package will break it.

@macrozone
Copy link
Contributor Author

Better declare it as weak-dependency and check if Template is there:

if(Meteor.isClient && global.Template) {

}

or here in coffeescript: Template?.registerHelper

@dr-dimitru
Copy link
Member

@macrozone thank you for suggestion, will use it in further release

@macrozone macrozone mentioned this issue Oct 6, 2016
Merged
dr-dimitru added a commit that referenced this issue Oct 12, 2016
@dr-dimitru
v1.7.4
be73637 
This is first updated based on community contribution.
Thank you everyone who has a chance to take a part in this project,
you've made this lib better!

v1.7.4:
 - Comparability with `meteor@1.4.1.2`
 - Update Google integration docs - @salmanhasni
 - `.find()` and `.findOne()` methods of `FilesCollection` now acts in
the same way as instances of `Mongo.Collection` - @exKAZUu
 - Explanation around `storagePath` option - @elewis33 & @yanickrochon
 - Option to set different DDP connection, per Collection and per
Upload. By @rafaelcorreiapoli - closing #51 and #235
 - `Template` now is weak dependency, by @macrozone - closing #242
 - Demo app: UI fixes for Safari
 - Demo app: Notice if video or audio not supported by browser. The
__.mp4__ was deprecated in Chromium in favour of __.webm__
@dr-dimitru dr-dimitru mentioned this issue Oct 12, 2016
Merged
dr-dimitru added a commit that referenced this issue Oct 12, 2016
@dr-dimitru
Merge pull request #265 from VeliovGroup/dev
5e78b51 
v1.7.4
This is first update based on community contribution.
Thank you everyone who has a chance to take a part in this project, you've made this lib better!

v1.7.4:
 - Comparability with `meteor@1.4.1.2`
 - Update Google integration docs - @salmanhasni
 - `.find()` and `.findOne()` methods of `FilesCollection` now acts in the same way as instances of `Mongo.Collection` - @exKAZUu
 - Explanation around `storagePath` option - @elewis33 & @yanickrochon
 - Option to set different DDP connection, per Collection and per Upload. By @rafaelcorreiapoli - closing #51 and #235
 - `Template` now is weak dependency, by @macrozone - closing #242
 - Demo app: UI fixes for Safari
 - Demo app: Notice if video or audio not supported by browser. The __.mp4__ was deprecated in Chromium in favour of __.webm__
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Template is now a weak depencency panter/Meteor-Files
2 participants
@dr-dimitru @macrozone