-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add throttle support #40
Conversation
@NROL39 why? I mean what this PR actually fixes/enhances |
It adds throttling support, let's say you have a hundred users, your server has 100mbps bandwidth, at the moment what will happen is that you'll be sending data as fast as possible, choking the other connections (try downloading multiple large files at the same time, you'll notice some will be downloading at a fast rate while some will have much lower rate). Basically, it's so you can divide resources between multiple clients without having clients interfere with each other's downloads |
@NROL39 got it, but why not make build in (all pipes by default) with ability to change (bps). Now if user does not passes |
That's right, I feel this should be an opt-in feature rather than an opt-out (although that is entirely up to you) |
Better to have it enabled by default. But we need to specify default bps? Which value will be optimal? |
Well, it depends on the server's bandwidth, average file size and concurrent user count, every project will have it's own optimal range which is why i think it should be opt-in. |
Agree now. |
There we go, 206 support added. |
@NROL39 Thank you. I'll run tests, then merge and publish |
Could you also add |
No description provided.