Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add context.chunkId and context.eof to onBeforeUpload #82

Merged
merged 3 commits into from
May 23, 2016
Merged

add context.chunkId and context.eof to onBeforeUpload #82

merged 3 commits into from
May 23, 2016

Conversation

menelike
Copy link
Contributor

This adds chunkId and eof as context for onBeforeUpload to help solving #79

This is needed to determine if validation based on meta should fire. We need to know when to expect metadata since metais transmitted on the first and last chunk only.

@dr-dimitru
Copy link
Member

We also need to pass the chunkId and eof to onBeforeUpload on the client to meet isomorphicity.

@menelike
Copy link
Contributor Author

menelike commented May 22, 2016

@dr-dimitru
Copy link
Member

You're right, then we need to emphasise what this properties is Server only

Emphasize that chunkId and eof are accessible on server only
@menelike
Copy link
Contributor Author

I updated the docs, hope this fits now.

@dr-dimitru dr-dimitru merged commit 7a277ee into veliovgroup:dev May 23, 2016
@dr-dimitru
Copy link
Member

Great, thank you. Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants