-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library is not compatible with Node 8.9.3 #270
Comments
Hi @utillity, thanks for opening the issue. On MDN, it says that the exception part can be omitted (see also their example):
The optional catch binding should be well supported by vendors and tools (see compatibility data). Can you share some details about how you are getting the error (tools, Node or browser version, commands used) ? |
Hi, I am using this library with node 8.9.3 on an embedded device (unfortunately I can't install a newer node version there). if you want to make it backward-compatible that would be great :) I'm just using |
uff, looks like there are a couple of issues blocking me from using your library with node 8.9.3 - don't need to fix the catch :) |
That's unfortunate, what are the other issues if you don't mind? Maybe you could try compiling (part of) the library for your use case or use something like patch-package in your install step. If you want to implement something yourself to fetch manifests from npm the endpoints look like this |
this old nodejs version also doesn't support Object.fromEntries. I could pull and try to get everything working, if you need it. I found a simple workaround which works for me - I just use fetch() to get the JSON directly from my private repository, so no dependencies needed :) |
I see. Don't worry about the PR, supporting older versions is not a priority right now and I plan to use features available in current and future releases anyway (like native I'm glad you found a solution that works for you. |
it should be
catch (err) { }
as per MDNThe text was updated successfully, but these errors were encountered: