Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of Rust Nightly + Dependency Updates #6

Merged
merged 7 commits into from
Dec 13, 2023

Conversation

LunaticWyrm467
Copy link
Contributor

Hi there!
I saw this fantastic crate and I tried to use it on the latest version of rust, only to notice that this crate failed to compile due to a few issues, such as some outdated crates failing to run.
So, I took the liberty of pushing out a pull request with the dependencies updated for you, and also I switched back to the original packed_simd crate.

This was checked and tested on rust 1.76.0-nightly.
Oh, and I added the Clone derive to a few types to allow for better compatibility with some types, so some key types could be included in wrapper structs that derive from Clone.

@velvia
Copy link
Owner

velvia commented Dec 8, 2023

Hey @LunaticWyrm467 thank you so much. I had started working on another PR that was trying to update the build but couldn't get that one to build. Too many distractions!

I approved the build and it seems to fail, but it also seems to be trying to build on stable. Weird.
Let me pull this locally and try it out.

@velvia
Copy link
Owner

velvia commented Dec 8, 2023

Oh, the rust-toolchain was deleted. Say would you mind updating it to 1.76.0-nightly? That's likely why the CI fails.

@LunaticWyrm467
Copy link
Contributor Author

Yeah, I removed it in favor of a cargo version override while testing, mostly because I had issues on my end getting it to build initially. Looks like I may have forgotten to add it back, I'll do that when I get the chance!

@LunaticWyrm467
Copy link
Contributor Author

Try that. Let me know if anything else fails.

@velvia
Copy link
Owner

velvia commented Dec 9, 2023

Thanks @LunaticWyrm467 .... the tests seem to pass but the doctests fail. Actually they look more like compile failures than doctest failures, it's very weird.... I'll see if I have time to look into it.

https://github.com/velvia/compressed-vec/actions/runs/7142826807/job/19472246385?pr=6

@LunaticWyrm467
Copy link
Contributor Author

Huh. strange. Well, if you need any help, let me know.

@velvia
Copy link
Owner

velvia commented Dec 13, 2023

They are doctest errors. I'll merge and then fix later. Thanks again.

@velvia velvia merged commit 81f6f7a into velvia:main Dec 13, 2023
1 check failed
@LunaticWyrm467
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants