Pretty -> Pyro [WIP] #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the old Aviso/Pretty-based stacktrace engine with a new one basd off Pyro. I've run into some minor issues with this so I'm going to do some more debugging to figure out exactly what the root cause is.
Previously the ultra.hardcore-test namespace didn't actually load ultra.hardcore. This is important because there were some compile-time issues that should have been caught in test but weren't due to the fact that we weren't actually trying to load the namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the tracking PR for the 0.6.0 release. Because this release includes a major change (the switch from Pretty to Pyro for stacktraces), I'm letting it "bake" for a while. This gives me time to iron out kinks and make sure it's not going to be a negative experience for other devs when they switch over.