This repository has been archived by the owner on Dec 28, 2023. It is now read-only.
Add a longer description for each track #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlopes
approved these changes
Nov 15, 2018
edsrzf
reviewed
Nov 15, 2018
constants.js
Outdated
| @@ -159,7 +160,8 @@ export const tracks: Tracks = { | |||
| WEB_CLIENT: { | |||
| displayName: "Web client", | |||
| category: "A", | |||
| description: "Develops expertise in web client technologies, such as HTML, CSS, and JavaScript", | |||
| summary: "Develops expertise in web client technologies, such as HTML, CSS, and JavaScript", | |||
| description: "We need to provide our users with a modern, responsive web product that renders well across all major browsers. We need engineers with expertise in web client technologies to help us continue to build industry-leading technology like our editor and take advantage of new opportunities like AMP.", | |||
There was a problem hiding this comment.
This particular one is still fairly specific to Medium in some ways: "industry-leading technology like our editor"
|
Yeah sorry my bad, the PR was mainly to add the field! I didn't look at the
copy yet, I'll change it in another PR :)
…On Thu, 15 Nov 2018 at 14:56, Evan Shaw ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In constants.js
<#7 (comment)>:
> @@ -159,7 +160,8 @@ export const tracks: Tracks = {
WEB_CLIENT: {
displayName: "Web client",
category: "A",
- description: "Develops expertise in web client technologies, such as HTML, CSS, and JavaScript",
+ summary: "Develops expertise in web client technologies, such as HTML, CSS, and JavaScript",
+ description: "We need to provide our users with a modern, responsive web product that renders well across all major browsers. We need engineers with expertise in web client technologies to help us continue to build industry-leading technology like our editor and take advantage of new opportunities like AMP.",
This particular one is still fairly specific to Medium in some ways:
"industry-leading technology like our editor"
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGZtpn4xVyAmXT6y3bNeO8adycJ4Upl5ks5uvMncgaJpZM4YetCW>
.
--
Céline Rufener
Lead Engineer
+64 22 353 7983
www.vendhq.com <http://vendhq.com/> | We're hiring |
<https://www.vendhq.com/careers>@vendhq <https://twitter.com/vendhq>
| Watch
the video <https://www.youtube.com/watch?v=KufpSFDynZE&t=2s>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed the field
descriptiontosummaryand added the fielddescription. The summary is a short sentence (shown in italic) describing each track whereas the description provides more information/context.