Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix java errors #89

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix java errors #89

wants to merge 2 commits into from

Conversation

agopalan87
Copy link
Contributor

Fix java code errors. Code compilable in Java 17

Copy link
Member

@richard-rance richard-rance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the docs. I'm curious where you are trying them out.

@agopalan87
Copy link
Contributor Author

Thanks for improving the docs. I'm curious where you are trying them out.
I was trying them in my local to understand the 2legged oauth

.withSubject((String) credentials.get("assertionPayloadData").get("sub"))
.withAudience((String) jsonObject.get("aud"))
.withIssuer((String) jsonObject.get("iss"))
.withSubject((String) (JSONObject)credentials.get("assertionPayloadData").get("sub"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand your last commit. Instead of renaming the variables like I suggested you changed just this one line back to almost what it was before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants