Fix tests. #24
Merged
Fix tests. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary issue was the LiveScript adding a header. I am guessing the version of livescript got updated but the tests did not get updated to match. Also the "fetch_state.js" file seemed to have Mac-style newlines (i.e. ^M) but the expected result did not. Also it used actual tabs instead of spaces like the other files. Just to ensure consistancy I changed everything on that file to regular newlines (Unix style) an replaced the tabs with spaces. Finally I added a bit of info to the README on how to run the tests. Since it doesn't use a standard approach, it wasn't immediately obvious to me. The documentation should hopeful help others that need to run the tests.
Thanks for tabs. And damn mac, I guess I'll avoid working on two differents systems...
Definitely unusual. Looks good, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary issue was the LiveScript adding a header. I am guessing the
version of livescript got updated but the tests did not get updated to match.
Also the "fetch_state.js" file seemed to have Mac-style newlines (i.e. ^M) but
the expected result did not. Also it used actual tabs instead of spaces like
the other files. Just to ensure consistancy I changed everything on that file
to regular newlines (Unix style) an replaced the tabs with spaces.
Finally I added a bit of info to the README on how to run the tests. Since
it doesn't use a standard approach, it wasn't immediately obvious to me. The
documentation should hopeful help others that need to run the tests.