Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product & Variant visibility #62

Closed
michaelbromley opened this issue Feb 11, 2019 · 1 comment
Closed

Product & Variant visibility #62

michaelbromley opened this issue Feb 11, 2019 · 1 comment

Comments

@michaelbromley
Copy link
Member

There should be a flag which allows a Product or ProductVariant to be made invisible in the front-end.

To view hidden products, there could be an extra option flag in the list options input / search input.
Since only admin should be able to view hidden entities, there must exist some logic which checks the user permissions before returning hidden results. Perhaps an error should be thrown if the flag is set to true when the user lacks sufficient permissions.

@michaelbromley michaelbromley added this to To do in Beta Mar 1, 2019
@michaelbromley michaelbromley moved this from To do to In progress in Beta Apr 23, 2019
@michaelbromley
Copy link
Member Author

michaelbromley commented Apr 23, 2019

Notes

Now that we have a separate API for shop & admin, this simplifies how we treat invisible products - simply filter them out for the shop API.

Also we can rename the concept to "enabled" rather than "visible".

Disabling a product or variant implies that it must also be removed from the search index and from any collections to which it belongs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Beta
  
Done
Development

No branches or pull requests

1 participant