-
-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product & Variant visibility #62
Labels
Projects
Comments
NotesNow that we have a separate API for shop & admin, this simplifies how we treat invisible products - simply filter them out for the shop API. Also we can rename the concept to "enabled" rather than "visible". Disabling a product or variant implies that it must also be removed from the search index and from any collections to which it belongs. |
michaelbromley
added a commit
that referenced
this issue
Apr 24, 2019
michaelbromley
added a commit
that referenced
this issue
Apr 24, 2019
michaelbromley
added a commit
that referenced
this issue
Apr 24, 2019
michaelbromley
added a commit
that referenced
this issue
Apr 24, 2019
michaelbromley
added a commit
that referenced
this issue
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There should be a flag which allows a Product or ProductVariant to be made invisible in the front-end.
To view hidden products, there could be an extra option flag in the list options input / search input.
Since only admin should be able to view hidden entities, there must exist some logic which checks the user permissions before returning hidden results. Perhaps an error should be thrown if the flag is set to
true
when the user lacks sufficient permissions.The text was updated successfully, but these errors were encountered: