Removed shipping address & customer email from payment intent metadata

[yasserlens]

This should solve #2364

Removed shipping address and customer email from payment intent request metadata. This is because Stripe express payments require a payment intent, but at the point of doing an express payment we may not have customer details (they are fetched from the payment resolver, such as Google/Apple pay.

[netlify]

✅ Deploy Preview for effervescent-donut-4977b2 canceled.

Name	Link
🔨 Latest commit	a4f77f0
🔍 Latest deploy log	https://app.netlify.com/sites/effervescent-donut-4977b2/deploys/64eba1a5f7d2710007257e36

[michaelbromley]

Hi, thanks for the detailed investigation and PR.

I'm not understanding something about this though:

Removed shipping address and customer email from payment intent request metadata

I don't see this in the changes to the PR. All I see is that you are removing the call to options.metadata().

[yasserlens]

Hey Michael

options.metadata() is deconstructed, generating the following pairs when an order has no customerEmail or shippingAddress attached:

{
"customerEmail": "unknown",
"shippingAddress": "undefined undefined, undefined, undefined undefined, undefined",
}

Removing the call you referred to should omit the key-value pairs above. The rest are hard-coded:

{ 
channelToken: ctx.channel.token,
orderId: order.id,
orderCode: order.code,
}

The unit tests don't check for shippingAddress, but they check for the customerEmail field, which is why I removed it from the checks to make the tests pass.

[michaelbromley]

options.metadata() is deconstructed, generating the following pairs when an order has no customerEmail or shippingAddress attached:

What I'm not understanding is that by default, the options.metadata function is undefined. This means that unless you yourself are defining a metadata function which returns the customerEmail and shippingAddress keys, how is this being included in the metadata that gets sent to Stripe?

[yasserlens]

Great Catch - Michael. I actually do define this metadata in Stripe's config when setting up (in vendure-config.ts).
The reason why they're their is to make sure customer details are attached to the payment, so we could find the customer payment in Stripe if needed given shipping info.

We can remove this and this should solve the issue without going with this change.
However, keeping such metadata which can change from one call to another for the same order could result in this happening again to other Stripe plugin users. Do we want to keep this metadata in the paymentIntent.create() call?

Happy to discard the change if you think it's necessary to keep it.

[michaelbromley]

Thanks for the clarification. I'm gonna close this because I don't think it's the right direction for a solution. I've made another suggestion in the original issue.