fix(mollie): Add missing status type

[casperiv0]

Description

Adds a missing status field to the molliePaymentMethods query. This type was previously not typed by Mollie. It is documented however.

PR on Mollie's API plugin: mollie/mollie-api-node#335

Breaking changes

None.

Checklist

📌 Always:

• I have set a clear title
• My PR is small and contains a single feature
• I have checked my own PR

⚡ Most of the time:

• I have added or updated test cases
• I have updated the README if needed

[netlify]

❌ Deploy Preview for effervescent-donut-4977b2 failed.

Name	Link
🔨 Latest commit	2c00333
🔍 Latest deploy log	https://app.netlify.com/sites/effervescent-donut-4977b2/deploys/65411714d6c96500085e67f7

[casperiv0]

Not sure if the generated types have to be included, my guess is that they're formatting changes. yarn format seems to be configured incorrectly, unfortunately?

[michaelbromley]

Hi!
Thanks for the PR 👍
@martijnvdbrug would you mind just quickly reviewing the addition of the field here?

Regarding the generated type files - yes they should be updated just to add this new field, but that should be a single line change. What happens if you run codegen without then formatting afterwards?

[casperiv0]

Regarding the generated type files - yes they should be updated just to add this new field, but that should be a single line change. What happens if you run codegen without then formatting afterwards?

Should be resolved now :)!

[martijnvdbrug]

Well, the Mollie API only returns active payment methods, so this field will always return 'activated'. What is the reason for adding this field?

[casperiv0]

Well, the Mollie API only returns active payment methods, so this field will always return 'activated'. What is the reason for adding this field?

It doesn't actually! It will also return ones with status null. We want to be able to manually remove those in our codebase

[michaelbromley]

It doesn't actually! It will also return ones with status null.

Is that a bug in the Mollie API or SDK? We're using the mollie client methods.list method:

vendure/packages/payments-plugin/src/mollie/mollie.service.ts

Line 339 in 2f7a8d5

const methods = await client.methods.list({ resource: 'orders' });

and the jsdoc for that method says:

Retrieve all enabled payment methods. The results are not paginated.

whereas in the mollie docs it says that null signifies that the payment has not been requested

so what doesn't make sense to me is how a "not requested" (null) method can at the same time be "enabled". Something doesn't add up.

[casperiv0]

Yeah, does seem to be a bug in the Mollie API. Additional context: We're loading the enabled Mollie payment methods, however, "Vouchers" show up with status null. They cannot be disabled directly via the Mollie dashboard.
The quickest way was to filter out the invalid statuses while waiting to hear back from Mollie.

[michaelbromley]

OK, thanks for the clarifications. There's no harm adding this field even in future if Mollie fixes their probably bug and then it will just always be "activated"

[martijnvdbrug]

Oh wow, good find. Then yes, in this case we should just proxy the status field. Thanks!