Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOXELFORMAT: VOX: flips, instances, rotates not handled correctly #275

Closed
mgerhardy opened this issue Apr 18, 2023 · 3 comments
Closed

VOXELFORMAT: VOX: flips, instances, rotates not handled correctly #275

mgerhardy opened this issue Apr 18, 2023 · 3 comments
Labels
bug format-mv-vox MagicaVoxel

Comments

@mgerhardy
Copy link
Collaborator

mgerhardy commented Apr 18, 2023 •
edited

test.zip

vengi:
Bildschirmfoto vom 2023-04-18 07-50-07

voxelmax:
Voxel_Max_2023 04 18_09 54 012x

magicavoxel:
MagicaVoxel_2023 04 18_09 53 182x

https://github.com/Zylann/godot_voxel/blob/57baa553221aeff45be3ff46caa3261819a473bd/streams/vox/vox_data.cpp#L150
@mgerhardy
Copy link
Collaborator Author

it's a good test for rounding issues too, because we'll get offsets otherwise on one of the flipped objects here
Voxel_Max_2023 04 18_09 55 472x

@mgerhardy mgerhardy mentioned this issue Apr 18, 2023
Closed
mgerhardy added a commit that referenced this issue Jun 30, 2023
@mgerhardy
VOXELFORMAT: VOX: flips, instances, rotates not handled correctly #275
9634f3a
@mgerhardy mgerhardy reopened this Jul 8, 2023
mgerhardy added a commit that referenced this issue Jul 8, 2023
@mgerhardy
VOXELFORMAT: VOX: refactored format to support references
3b0acdf 
there are still problems with flip matrices and backside culling

see pull request #296 and issue #255

This more or less opens #275 again
@mgerhardy
Copy link
Collaborator Author

Bildschirmfoto vom 2023-07-08 07-28-58

introduced this backside culling problem with the recent commit.

@mgerhardy
Copy link
Collaborator Author

I've reverted the backside-culling-issue commit again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug format-mv-vox MagicaVoxel
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mgerhardy