Swift 4.2 / Xcode 10 Compatibility #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliperkins
approved these changes
Sep 18, 2018
|
Thanks for the PR @cocoahero , I keep thinking CI was set up to validate this repo but wasn't seeing it here in the merge status. Was thinking we may need to update travis sdk? Will check after work. |
|
You are correct that the |
|
@dmiluski @eliperkins is there anything I can do to help get this PR finalized? |
|
Looks good @cocoahero , I'll get this merged/released today |
|
oops, merged and looks like there's a failure with Travis CI which ran after merge. Will fix shortly, and get CI wired back up to this repo for PR validation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.