Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax the gem requirement #103

Closed
wants to merge 2 commits into from
Closed

Relax the gem requirement #103

wants to merge 2 commits into from

Conversation

siuying
Copy link

@siuying siuying commented Mar 7, 2016

This gem don't really need exactly those versions of dependencies. Relax the requirement will allow us use it when some other gems depended on a higher version.

@siuying siuying mentioned this pull request Mar 7, 2016
@clementpadovani
Copy link

+1

@kylef
Copy link
Contributor

kylef commented Mar 7, 2016

As per semantic versioning, newer releases of those dependencies may change their APIs and subsequently break synx in the future. There is no way to say for sure that synx will work with future versions that break the API.

So 👎 on this change.

spec.add_dependency "clamp", "~> 0.6"
spec.add_dependency "colorize", "~> 0.7"
spec.add_dependency "xcodeproj", "~> 0.28.2"
spec.add_dependency "clamp", ">= 0.6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clamp now has a 1.0 release, I think making it ~> 1.0 would be acceptable (providing it works in synx).

@siuying
Copy link
Author

siuying commented Mar 7, 2016

@kylef I theory thats true, in reality its more complicated. What proper version would you think appropriate? IMHO "xcodeproj", "~> 0.28.2" is definitely not correct.

I have tested the gem work on clamp 1.0.0 and xcodeproj 1.0.0.beta.3., I could write:

"xcodeproj", ">= 0.28.2, <= 1.0.0.beta.3"

but one would need to update it again for 1.0.0.beta.4

@kylef
Copy link
Contributor

kylef commented Mar 29, 2016

What proper version would you think appropriate?

In an ideal world, Xcodeproj would be 1.0.0 and then you can depend on it as ~> 1.0. Until then, I think pinning to the latest 0.minor would be sufficient.

@siuying
Copy link
Author

siuying commented May 9, 2016

Will close this and wait for Xcodeproj release. If one need a temporary workaround please use the branch above.

@siuying siuying closed this May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants