Add support for find_optional with an updated_at query #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnusvk
approved these changes
May 24, 2019
There was a problem hiding this comment.
@tonybruess given that you're raising a NotUpdatedError, not the NotFoundError this will end up in normal error handling (the special handling for NotFoundError is here. Aka, it'll be in the retries queue, get retried with normal backoff and eventually complain that it's failing if it stays there.
I think that's correct behavior, just want to make sure that's 👍 with you.
|
Yep! That's the intended behavior :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.