Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample app required #9

Open
martinvalenta opened this issue Oct 11, 2016 · 26 comments
Open

Sample app required #9

martinvalenta opened this issue Oct 11, 2016 · 26 comments

Comments

@martinvalenta
Copy link

Is there any sample app available which shows how to integrate MusicKit into one own's project?

I can build the project, especially the frameworks. However, when I try to include the framework via #import <MusicKit/MusicKit.h> I get the error Could not build module 'MusicKit'. Also, the expression FOUNDATION_EXPORT in MusikKit.h causes trouble. In that header I also get multiple file not found errors, e.g. for #import <MusicKit/VMKColor.h>.

Is there something wrong with the project set-up or am I missing something?

@alejandro-isaza
Copy link
Collaborator

There were some project settings that needed to be adjusted. Try my fork: https://github.com/aleph7/musickit

@martinvalenta
Copy link
Author

That did the trick! Thanks!

Where should I push code improvements to? To this repository or to your fork?

@alejandro-isaza
Copy link
Collaborator

You can post them here. I'll merge my changes here as well.

@ivan-milic
Copy link

I have the same problem as martinvalenta posted. Are there any solutions?

@aidangomez
Copy link
Contributor

@ivan-milic Did you try @Aleph7's fork?

@ivan-milic
Copy link

@aidangomez aren't those two the same now?

@aidangomez
Copy link
Contributor

aidangomez commented Nov 18, 2016

@ivan-milic No, I don't think @martinvalenta ever PR'd his changes here.

@alejandro-isaza
Copy link
Collaborator

I did merge my changes here.

@aidangomez
Copy link
Contributor

@Aleph7 Whelp, nevermind.

@ivan-milic
Copy link

@Aleph7 Are you aware what was the problem because i am having the exact same that @martinvalenta mentioned. And btw, do you, by any chance, have any sample application that uses your framework just so i can see how it's used?

@alejandro-isaza
Copy link
Collaborator

It was a problem with the project settings. Maybe something changed again in Xcode 8.1. I'll look into it in the next couple of days. There is a sample preview app in the project but that is the only thing that is publicly available.

@alejandro-isaza
Copy link
Collaborator

@ivan-milic can you run PreviewGenerator? It works fine for me. It currently doesn't support any package manager because it has C++ dependencies but you can include all the sources directly on your project.

@ivan-milic
Copy link

@Aleph7 yes, i can run the PreviewGenerator. I get the above mentioned error when i import the MusicKit.framework into another project and try to build it. Also when i import the MusicKit header into the MusicKitApp inside this project, i get the "cmath file not found" error when i try to build it.

@ivan-milic
Copy link

@Aleph7 I changed the build settings for MusicKitApp target to compile sources as Objective-C++ rather than "According to file type" and i can build it successfully. I just wish there was a manual for using this framework or like a sample iOS app which just shows how to read a musicXML file and display the sheet music in the app.

@dkun7944
Copy link
Contributor

@Aleph7 I am getting the error 'mxml/geometry/Point.h' when I include MusicKit.framework in my separate Xcode project. It seems like it's not finding any of the mxml headers. Can you help?

@alejandro-isaza
Copy link
Collaborator

make sure you run git submodule update --init --recursive

@dkun7944
Copy link
Contributor

dkun7944 commented Apr 27, 2017

@Aleph7 Thanks. Getting a different error now (making progress!) The MusicKitApp builds and runs successfully but my app still doesn't. I tried changing the target to compile sources as Objective-C++ rather than "According to file type" I'm getting:

'cmath' file not found

and

Include of non-modular header inside framework module 'MusicKit.VMKGeometry': .../Point.h

Thanks for getting back to me so quickly!

@alejandro-isaza
Copy link
Collaborator

No problem. Make sure you have C++11 as the compiler. Not sure about the header thing, I'll have look later.

@dkun7944
Copy link
Contributor

@Aleph7 Figured it out. In MusicKit.framework, the build setting 'Allow Non-modular Includes in Framework Modules' should be set to YES.

@dkun7944
Copy link
Contributor

@Aleph7 Let me know when you have a chance to take a look. Still having issues with it finding the mxml lib, but PreviewGenerator compiles and runs great.

@alejandro-isaza
Copy link
Collaborator

I though that was fixed, did you try git submodule update --init --recursive? I just cloned, ran that then pod install and everything compiled fine.

@dkun7944
Copy link
Contributor

@Aleph7 yes, but if you try to import MusicKit (not MusicKitOSX) inside the a file in MusicKitApp, it does not compile.

@dkun7944
Copy link
Contributor

@Aleph7 Any chance we could get a sample iOS app to see how this is implemented? Trying to use VMKPageScoreLayout and VMKPageScoreDataSource but getting null pointer exceptions.

@alejandro-isaza
Copy link
Collaborator

Sorry, wish I could help, haven't worked on this in a while and am pretty busy.

@cerupcat
Copy link

Curious if there's an update on this. Would love to see a simple sample app that demonstrates the capabilities.

@cerupcat
Copy link

cerupcat commented Feb 17, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants