Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DCA script #14

Closed
wants to merge 1 commit into from
Closed

Add DCA script #14

wants to merge 1 commit into from

Conversation

Dessoul
Copy link

@Dessoul Dessoul commented May 8, 2017

A script that pass configured market order when called, used in DCA strategy

A script that pass configured market order when called, used in DCA strategy
@veox veox self-requested a review May 8, 2017 21:29
Copy link
Owner

@veox veox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providing an example configuration file (with keypath/pair/type/volume, not keyfile) would be highly desirable.


chaine_erreur = ""

for ligne in data:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a rather convoluted way of reading in configuration. :)

If there's a file with python syntax, e.g. DCABot.config.py, it can be imported and used directly. E.g., like this.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't have time to work on it now, I could revisit it later myself.

@veox veox mentioned this pull request May 8, 2017
@Dessoul
Copy link
Author

Dessoul commented May 9, 2017

Hi. I made the configuration file example, but I did not succeed to add this in this pull request.
Anyway this is somewhere in this repo. Sorry for the mess.
Really interesting your example, I will remind this. To be honest I never used Python before this :)
But I am not sure how to use it with multiple instances of the same variables, so I think it will be more efficient if you have a look by yourself.
Once again, thank you for the work you did here.

@veox
Copy link
Owner

veox commented Jul 22, 2017

I'm closing this PR for now, since I don't have the time to re-work it to be straightforward ATM.

Issue #30 links here for tracking purposes.

@veox veox closed this Jul 22, 2017
@veox veox added the examples label Jul 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants