Json decode error instead of HTTPException #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case kraken server return something different that 20x response we shall throw an proper http exception. Otherwise it would try to parse JSON and we got JSONDecodeError exception which is confusing. This way developers could handle better connection problems in their apps in case kraken has problems.
Minor update when raising an exception lets show the status code so developer has more information what is going on.
|
Cool, thanks! Warrants at least a MINOR version bump, since function behaviour changed (now raises for a different reason). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case kraken has connection problems and it doesnt return 20x status code, we process the code and got Json decode error.
This is confusing as there is a problem with connection to Kraken not with the response it returned. Therefore I have updated connection to raise a proper exception. This way in application developers can handle kraken connection issues gracefully.