Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSGi compliant #5

Open
chuspb opened this issue Jan 16, 2017 · 2 comments
Open

OSGi compliant #5

chuspb opened this issue Jan 16, 2017 · 2 comments

Comments

@chuspb
Copy link

chuspb commented Jan 16, 2017

Hi,
Thanks for your project. We have built a wrapper of the library to be OSGi compliant. Do you want a PR in your project with this build?
Regards.

@veqryn
Copy link
Owner

veqryn commented Jan 17, 2017

Sure.
I'm not that familiar with OSGi, beyond some quick googling a minute ago, so a few questions:

  1. Will we need to bump the version number?
  2. Will we need to update the binaries in the maven repository?
  3. Will this change how people include this library as a dependency? And if so, can people still include it the old/normal way?
  4. Since this library doesn't actually have any dependencies (beyond 'test'), what does this do?
    thanks!,
    VEQ

@chuspb
Copy link
Author

chuspb commented Jan 17, 2017

Hi,
I'm answering point by point;

  1. That is up to you. If you update the version number (1.0.2 for example), then there is no doubt that this one is prepared to run in an OSGi environment.
  2. Yes, that will be nice. That way we can download the new version without uncaching the previous library (1.0.1) .
  3. There is no change. The library can be used in the same way. The only change is internal. Now, the jar is a bundle that can be deployed in any OSGi environment like Equinox, Apache Felix, Knopflerfish, ...
  4. It doesn't includes any other dependency. It just creates a MANIFEST.MF file that is interpreted by the OSGi environments.

I will do a PR afterwards. You are free to change the version number, checking the created jar and so on. Please, do contact if any doubt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants