Logr Interoperability

[veqryn]

go-logr/logr#234

[codecov-commenter]

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

[veqryn]

@pohly @thockin hey guys, i have a few requests:

1. Can you please make a new versioned release of logr, so I can update my go mod for it?
2. Are you good with this section added to my readme?
3. If you have time, I wouldn't mind a review of my library. In particular I am debating the names I've chosen, like for putting the logger in (ToCtx) and getting it out again (Logger).
   They would all be prefixed with slogcontext in user code...
   Putting the logger into a context and getting a context back could be: ToCtx, LoggerToCtx, WithLogger, CtxWithLogger, NewCtx, WithCtx, or just Ctx
   Getting it out again could be: Logger, ToLogger, CtxToLogger, LoggerFromCtx, WithLogger, or FromCtx

[thockin]

1. let's not rush (or we can do an rc1). I already found at least 1 (minor, because @pohly is awesome) bug, and I have proposed funcr support for slog.

2. yes

3. the whole lib or just the PR? I am known for being opinionated so be careful what you ask for. :)

[veqryn]

1. Ok
2. Thanks
3. As much as you have time for. I may not take all advice, but I will consider everything. My priority would be on settling the external api (naming and function signatures) for my whole lib, followed by everything else. The library is still new and still version 0.x.x, so there is room to change things.

[pohly]

README looks good to me.

I'll leave 3 to @thockin - he's better at criticizing naming than I am 😝

[thockin]

Here's some notes, take 'em or not :)

• package name vs repo name - weird when they are not the same.
• slogctx would be a great pkg name :)
• I prefer the NewContext / FromContext pattern to ToCtx / Logger, personally
• The rest seems pretty approachable!

[veqryn]

Here's some notes, take 'em or not :)

• package name vs repo name - weird when they are not the same.
• slogctx would be a great pkg name :)

I agree it is a little weird, though golang seems to support it well enough.
I actually based the name off all the already existing slog libraries under the slog blog/wiki: https://github.com/golang/go/wiki/Resources-for-slog
All of them seemed to be named slog-<something> and their root packages named slog<something>.

Now I am reconsidering, because slogctx is a good and short name...

• I prefer the NewContext / FromContext pattern to ToCtx / Logger, personally

Will probably do that. Or NewCtx and FromCtx

• The rest seems pretty approachable!

Thx @thockin