Upgrade data table #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/data-table/table.rb
Outdated
| @@ -119,7 +118,7 @@ def render_rows(collection) | |||
| html = "" | |||
| collection.each_with_index do |row, row_index| | |||
| css_class = @alternate_rows && row_index % 2 == 1 ? 'alt ' : '' | |||
| if @row_style && style = @row_style.call(row, row_index) | |||
| if @row_style && style == @row_style.call(row, row_index) | |||
There was a problem hiding this comment.
This may actually need to be assignment, otherwise what is style
There was a problem hiding this comment.
Good point and thanks. Fixed.
|
A working CI configuration, be still my heart. |
ronnietaylor
force-pushed
the
upgrade_data_table
branch
from
b6343c1
to
9c9a462
Compare
ronnietaylor
force-pushed
the
upgrade_data_table
branch
from
9c9a462
to
9510c66
Compare
aharpervc
reviewed
Feb 1, 2017
| [ | ||
| {name: 'Luke Skywalker', class: 'Jedi Knight', world: 'Star Wars', power_level: 50}, | ||
| {name: 'Emporer Palpatine', class: 'Sith Lord', world: 'Star Wars', power_level: 95}, | ||
| {name: 'Mithrander', class: 'Wizard', world: 'Middle Earth', power_level: 9001}, |
aharpervc
reviewed
Feb 1, 2017
| let(:collection) { | ||
| [ | ||
| {name: 'Luke Skywalker', class: 'Jedi Knight', world: 'Star Wars', power_level: 50}, | ||
| {name: 'Emporer Palpatine', class: 'Sith Lord', world: 'Star Wars', power_level: 95}, |
aharpervc
reviewed
Feb 1, 2017
| @@ -1,12 +1,12 @@ | |||
| require 'data-table' | |||
| require 'pry' | |||
aharpervc
reviewed
Feb 1, 2017
| @@ -0,0 +1,161 @@ | |||
| require 'byebug' | |||
| require 'pry' | |||
| require 'pry-byebug' | |||
There was a problem hiding this comment.
All three of these are missing from the gemspec
|
Preparation for locking apps at data-table v1.0 and moving axiom-rails to v2.0 Apps that include data-table gem: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still in progress....