Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors and inconsistencies in examples #603

Open
gbryant-arm opened this issue Apr 20, 2023 · 0 comments
Open

Errors and inconsistencies in examples #603

gbryant-arm opened this issue Apr 20, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers question Further information is requested sdk Something related to the Veracruz SDK

Comments

@gbryant-arm
Copy link
Contributor

Describe the bug

  • examples/rust-examples/audio-event-triangulation doesn't compile
  • A bunch of examples never get built. The following examples aren't picked up by workspaces/shared.mk:
    audio-event-triangulation
    darknet-inference-native (not merged yet)
    file-seek
    huffman-encoding
    image-processing
    logistic-regression
    nop
    prime-numbers-generator
    random-source
    string-search
    tflite-inference-native-mnist (not merged yet)
    
  • Some examples have no Makefile specifying the target (wasm32-wasi)
  • Many crates under examples/ are buried in directories with no Cargo.toml, making them impossible to be scanned by tools like rust-analyzer. NB: This is also an issue for sdk/
  • In light of Add VOD deployment job to GitHub workflows #597, we should wonder whether it makes sense to compile and run these examples in CI

To Reproduce
Check out examples/

@gbryant-arm gbryant-arm added bug Something isn't working good first issue Good for newcomers question Further information is requested sdk Something related to the Veracruz SDK labels Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers question Further information is requested sdk Something related to the Veracruz SDK
Projects
None yet
Development

No branches or pull requests

1 participant