-
-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several minor issues: typo, desktop file updates, etc #814
Comments
Ah! Additionally, perhaps it may be useful to include a /usr/sbin/mount.veracrypt such that VeraCrypt could be used from fstab (and libpam-mount?) Example: #!/bin/bash
DEV="$1"
MNTPT="$2"
VCOPTIONS=""
OPTIONS=""
shift 3
IFS=','
for arg in $*; do
case "$arg" in
truecrypt) VCOPTIONS=(${VCOPTIONS[*]} --truecrypt);;
system) VCOPTIONS=(${VCOPTIONS[*]} --mount-options=system);;
fs=*) VCOPTIONS=(${VCOPTIONS[*]} --filesystem=${arg#*=});;
keyfiles=*) VCOPTIONS=(${VCOPTIONS[*]} --keyfiles=${arg#*=});;
password=*) VCOPTIONS=(${VCOPTIONS[*]} --password=${arg#*=});;
pim=*) VCOPTIONS=(${VCOPTIONS[*]} --pim==${arg#*=});;
protect-hidden=*) VCOPTIONS=(${VCOPTIONS[*]} --protect-hidden=${arg#*=});;
slot=*) VCOPTIONS=(${VCOPTIONS[*]} --slot=${arg#*=});;
*) OPTIONS="${OPTIONS}${arg},";;
esac
done
/usr/bin/veracrypt --non-interactive --text ${VCOPTIONS[*]} --fs-options="${OPTIONS%,*}" ${DEV} ${MNTPT} |
…or fstab (proposed by unit193 at #814)
Thank you for this contribution.
Let me know if you have further comments or remarks. |
Wow, thanks very much, this is fantastic! About the only thing to note, seems you forgot to I do not have anything else to add. |
Thank you for spotting the missing file. I have added it in f462160. |
Howdy,
First off, thanks for maintaining VeraCrypt, as always.
Issue #1: typo in source
While looking at the new language support, I noticed there's a typo on line 1021 of src/Main/GraphicUserInterface.cpp
Gui->ShowInfo (LangStrin["LINUX_VC_RUNNING_ALREADY"]);
should instead be
Gui->ShowInfo (LangString["LINUX_VC_RUNNING_ALREADY"]);
While I'm on it, a lot of the IDM_ vs HK_ strings are just about the same, though I notice the DE translation of IDM_MOUNT_FAVORITE_VOLUMES has & in it. The latter, HK_, should be for hotkeys or thereabouts, but basically I'm just trying to ensure I add the language support correctly to my indicator patch. :)
Issue #2: Locale name output
Another minor one, I noticed when you run VeraCrypt from the console, it now will output the value of $LANG. This seems like something leftover from debugging.
Issue #3: Desktop file updates
So my .desktop file looks a bit different than the one upstream, and I'd like to reconcile that difference. Mine is below:
There are several differences:
If you were curious, the contents of said file is:
I thought there were other minor things, but at this time I am not remembering them so I guess they can't be too important. Thanks for your consideration.
The text was updated successfully, but these errors were encountered: