Add toggleable support for application indicators, off by default. #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y default. This tries to figure out, via wx-config, if you're using GTK2 or GTK3 and uses the associated Ayatana library.
|
Thank you for this contribution. This is actually something that I wanted to add to VeraCrypt but I never had a chance to look into it, so I will definitely merge this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea if this is actually something you want to optionally support upstream, but I guess just close this out if not.
This tries to figure out, via wx-config, if you're using GTK2 or GTK3 and uses the associated Ayatana library.
This just adds support, off by default, for building against the Ayatana libraries for indicator support. As I understand it, for GNOME this is somewhat required to have a tray icon as they don't support the xembed ones at all. This of course works in Xfce too and in places that don't have indicator support, it should fall back to tray icon. Like for tint2.
I have been led to believe tray icons aren't exactly going to work out in a wayland world at all, but as I use Xfce I mainly ignore wayland at this stage.