Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing hash function validation in RSA-PSS signatures #75

Closed
tolginator opened this issue Jun 1, 2022 · 0 comments · Fixed by #72
Closed

Missing hash function validation in RSA-PSS signatures #75

tolginator opened this issue Jun 1, 2022 · 0 comments · Fixed by #72

Comments

@tolginator
Copy link

RSA-PSS Sign() function ignores the boolean returned from rs.alg.hashFunc(). While the current code returns a valid hash function for RSA, the code is brittle and error-prone. The boolean return should be validated to ensure that there is a recognized hash function (check for a true value) and there is a hash function (hash = crypto.Hash is not zero).

File: go-cose/rsa.go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant