Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail-safe check on RSA #72

Merged
merged 3 commits into from
Jun 21, 2022
Merged

Fail-safe check on RSA #72

merged 3 commits into from
Jun 21, 2022

Conversation

shizhMSFT
Copy link
Contributor

@shizhMSFT shizhMSFT commented May 30, 2022

Although rs.alg.hashFunc() never returns false, this PR makes it sound even if we have programming errors.

Fixes #75

Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT shizhMSFT requested a review from a team May 30, 2022 08:07
@shizhMSFT shizhMSFT changed the title Fail-safe Check on RSA Fail-safe check on RSA May 30, 2022
rsa.go Outdated Show resolved Hide resolved
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@thomas-fossati thomas-fossati merged commit b741bed into veraison:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing hash function validation in RSA-PSS signatures
3 participants