-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve README.md examples #111
Conversation
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## main #111 +/- ##
==========================================
+ Coverage 89.74% 91.79% +2.04%
==========================================
Files 10 10
Lines 985 975 -10
==========================================
+ Hits 884 895 +11
+ Misses 67 54 -13
+ Partials 34 26 -8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 it!
@yogeshbdeshpande can you take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I don't have merge permissions, need someone to do that for me :) |
Done! and Thank you for the Excellent Work! |
This PR updates the examples in the README.md to make it clear that the errors should be handled someway and also clarify hash function requirements.
Fixes #106