Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct README to reflect the defork from mozilla/go-cose #69

Merged
merged 4 commits into from
May 25, 2022
Merged

Correct README to reflect the defork from mozilla/go-cose #69

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d7f0fd
Correct README to reflect the defork from mozilla/go-cose
yogeshbdeshpande May 24, 2022
bdf7078
Editorial corrections post review
yogeshbdeshpande May 24, 2022
04d6869
Incorporate Review Comments
yogeshbdeshpande May 24, 2022
5cc52c8
Incorporating Review Comments
yogeshbdeshpande May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ A golang library for the [COSE specification][cose-spec]

**Current Release**: [go-cose alpha 1][release-alpha-1]

While the project is *currently* forked from the upstream [mozilla/go-cose][mozilla-go-cose] project, the veraison and mozilla maintainers have agreed to decouple the fork, retire the mozilla/go-cose project and focus on [veraison/go-cose][veraison-go-cose] as the active project.
The project was *initially* forked from the upstream [mozilla-services/go-cose][mozilla-go-cose] project, however it was agreed between the Veraison and Mozilla maintainers to retire mozilla-services/go-cose project and focus on [veraison/go-cose][veraison-go-cose] as the active project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer using the active phrasing (i.e., as it was before) to the passive construction.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing wrong in introducing with a brief background of the initial state (earlier) and then thanking the original contributors (in present) and then moving on. In my view it flows well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what I am referring to is the change from the original:

the veraison and mozilla maintainers have agreed to [...]

to

it was agreed between the Veraison and Mozilla maintainers to [...]

(the former is better.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that was correct when the action was in progress, like I have agreed to hand over XYZ to you.

But once the handover happened that should also go to past tense, like It was agreed between UK and EU to part ways back in 2019.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it's not that the agreement has vanished. Or so I hope :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this is viewed far better than brexit :)


We thank the [mozilla maintainers and contributors][mozilla-contributors] for their great work that formed the base of the [veraison/go-cose][veraison-go-cose] project.
We thank the [Mozilla maintainers and contributors][mozilla-contributors] for their great work that formed the base of the [veraison/go-cose][veraison-go-cose] project.

## Installation

Expand Down