Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Deno #155

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Bump Deno #155

merged 4 commits into from
Jul 16, 2024

Conversation

lishaduck
Copy link
Contributor

I'm not sure if there's a required amount of time before you bump Deno to ensure stability, but I didn't see anything, thus I went ahead and bumped it.

Copy link

vercel bot commented Jun 9, 2024

@lishaduck is attempting to deploy a commit to the Vercel Deno Team on Vercel.

A member of the Team first needs to authorize it.

@lishaduck
Copy link
Contributor Author

Ping, @TooTallNate :)
I think Deno 44 should be stable enough by now.

Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vercel-deno ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 9:41am

@TooTallNate
Copy link
Collaborator

I'm seeing a failure on the "dump" example endpoint. Looks like we'll need to start shipping the deno.lock file as part of the Lambda:

error: Failed writing lockfile.
Caused by:
Read-only file system (os error 30) (for '/var/task/deno.lock')
Child exited with error exit status 1INIT_REPORT Init Duration: 602.12 ms	Phase: init	Status: error	Error Type: Runtime.ExitError

@lishaduck
Copy link
Contributor Author

lishaduck commented Jul 4, 2024

Huh. That's weird. I don't have the "authorization required to deploy," yet it still deployed. ¯\_(ツ)_/¯

EDIT: Missed your last comment.

@lishaduck
Copy link
Contributor Author

Ok, when you run deno, you need to add the --no-lock flag following 1.29, but maybe they switched another default?

@lishaduck
Copy link
Contributor Author

May I ask where those logs came from? Vercel? I'm not seeing how that's getting run.

@TooTallNate
Copy link
Collaborator

Huh. That's weird. I don't have the "authorization required to deploy," yet it still deployed. ¯_(ツ)_/¯

I had to manually approve it.

May I ask where those logs came from?

Yes, they were from the Vercel Logs tab.

I think it's fine to have the lockfile, but we'll need to add it to the list of files so that the file is present in the Lambda at runtime.

@lishaduck
Copy link
Contributor Author

Huh. That's weird. I don't have the "authorization required to deploy," yet it still deployed. ¯_(ツ)_/¯

I had to manually approve it.

Ah. That makes sense.

May I ask where those logs came from?

Yes, they were from the Vercel Logs tab.

I think it's fine to have the lockfile, but we'll need to add it to the list of files so that the file is present in the Lambda at runtime.

Ok, I can add it.

I think this handles it? It typechecks, at least.
You use PNPM, so you should tell corepack that.
You also _seem_ to use prettier with single quotes for js files.
Finally, pnpm/action-setup could get bumped with no changes.
The latest version just enforces that packageManager stays in sync.
src/deno-lambda.ts Show resolved Hide resolved
src/deno-lambda.ts Outdated Show resolved Hide resolved
src/deno-lambda.ts Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
.prettierrc Show resolved Hide resolved
src/deno-lambda.ts Outdated Show resolved Hide resolved
@TooTallNate TooTallNate merged commit dba4932 into vercel-community:main Jul 16, 2024
2 checks passed
@lishaduck lishaduck deleted the patch-1 branch July 16, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants