Amend behaviour for selecting path prefix in proc macro #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We encountered an issue deploying the `examples/route-merge` directory,
insofar as it worked locally, and worked with `vc --prebuilt`, but
deploying via the Vercel build system by running `vercel deploy`
resulted in all the API routes panicing.
This happens because:
- The routes are properly formed and specified from the rust runtime
package (typescript side). Meaning we create the correct Vercel
functions.
- However, no routes are picked up by the proc macro.
The `vercel deploy` command only uploads the current directory into
Vercel. Meaning when built via the Vercel build system, the
`examples/route-merge` directory does not appear to be part of a cargo
workspace. The path prefix specified then does not point to
`examples/route-merge/api/**.rs`, but instead to
`examples/route-merge/examples/route-merge/api/**.rs`, meaning no
routing are created.
The fix for this is to fall back to acting as if no `path` is specified
in the case where `{path}/api/main.rs` cannot be found.
ecklf
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered an issue deploying the
examples/route-mergedirectory, insofar as it worked locally, and worked withvc --prebuilt, but deploying via the Vercel build system by runningvercel deployresulted in all the API routes panicing.This happens because:
The
vercel deploycommand only uploads the current directory into Vercel. Meaning when built via the Vercel build system, theexamples/route-mergedirectory does not appear to be part of a cargo workspace. The path prefix specified then does not point toexamples/route-merge/api/**.rs, but instead toexamples/route-merge/examples/route-merge/api/**.rs, meaning no routing are created.The fix for this is to fall back to acting as if no
pathis specified in the case where{path}/api/main.rscannot be found.