fix crash when cloning locally #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dferber90
commented
Apr 6, 2024
| @@ -9,7 +9,9 @@ import { Header } from '@/components/header' | |||
| import { Toaster } from '@/components/ui/sonner' | |||
|
|
|||
| export const metadata = { | |||
| metadataBase: new URL(`https://${process.env.VERCEL_URL}`), | |||
| metadataBase: process.env.VERCEL_URL | |||
There was a problem hiding this comment.
I'm wondering if we can just remove this option altogether, as the default behavior seems to be exactly what we want.
https://nextjs.org/docs/app/api-reference/functions/generate-metadata#default-value
When VERCEL_URL is detected: https://${process.env.VERCEL_URL} otherwise it falls back to http://localhost:${process.env.PORT || 3000}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template crashes when cloning, even after
vc env pull, sinceVERCEL_URLis set to an empty string when pulling env var.