Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade @auth/nextjs #76

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Jun 22, 2023

nextauthjs/next-auth@179c08d

Spent two hours on this. :upside_down_cry:
The x-forwarded-proto header returns https, but URL#protocol returns https:.

This made our cookies not being properly set in secure (HTTPS) environments, causing various issues when deployed.

Fixes #28

You can run pnpm up @auth/nextjs in your own project to apply this fix.

@vercel
Copy link

vercel bot commented Jun 22, 2023

@balazsorban44 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@balazsorban44 balazsorban44 mentioned this pull request Jun 22, 2023
@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai-chatbot ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 0:48am

@balazsorban44 balazsorban44 changed the title fix: upgrade @auth/nextjs chore: upgrade @auth/nextjs Jun 22, 2023
@shuding shuding merged commit 8c30c1f into vercel:main Jun 22, 2023
2 checks passed
@balazsorban44 balazsorban44 deleted the fix/next-auth-protocol-detection branch June 22, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup github login
2 participants