-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve docs & error handling for image parts #1569
Conversation
I think it could be smarter What if you added "if str startsWith (base64) doNothing else add Base64 |
@bernaferrari I considered that. There are many variants of this, in particular considering other URLs. The result would be that there are many examples out there for all variants of this method, increasing the maintenance burden and hindering future changes. |
{ type: 'text', text: 'Describe the image in detail.' }, | ||
{ | ||
type: 'image', | ||
image: new URL( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the new URL()
part was hard to find to get images to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was easier to find using github search than here 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes that are different from openai standard that everywhere is used don't make me happy
Summary
AI_InvalidDataContentError