Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added missing CSS unit #1

Merged
merged 1 commit into from
May 4, 2022
Merged

fix: added missing CSS unit #1

merged 1 commit into from
May 4, 2022

Conversation

emeraldsanto
Copy link
Member

Description

This PR adds a missing px unit to the top offset that is applied to the body when calling disableBodyScroll.

Related Issue(s)/Incident

Slack message

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Refactor (non-breaking change that is code cleanup)
  • Configuration & build (webpack, linters, GitHub templates, etc)

@emeraldsanto emeraldsanto self-assigned this May 2, 2022
@emeraldsanto emeraldsanto requested a review from a team May 2, 2022 16:49
@emeraldsanto emeraldsanto merged commit 6235144 into master May 4, 2022
@emeraldsanto emeraldsanto deleted the fix/ios-oddities branch May 4, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tknickman tknickman tknickman approved these changes

Assignees

@emeraldsanto emeraldsanto

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@emeraldsanto @tknickman