Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: switching languages does not update currency locale format #43

Closed
robbieaverill opened this issue Oct 29, 2020 · 2 comments
Closed

Comments

@robbieaverill
Copy link

Steps to reproduce:

  • Go to https://demo.vercel.store/search?q=accessories
  • Scroll to bottom, change English to Español
  • Notice things update, but price formats remain in US locale
  • Refresh the page
  • Notice price formats are now shown in Spanish locale format

Expected: locale formats should update with the rest of the DOM repaint, rather than requiring a page refresh

@okbel
Copy link
Contributor

okbel commented Nov 2, 2020

We currently don't support multi-currency. Please, open one issue per topic.
It's in our roadmap! Thank you.

@okbel okbel closed this as completed Nov 2, 2020
@robbieaverill
Copy link
Author

robbieaverill commented Nov 2, 2020

Thanks for the reply. As far as I can tell from the UI and the demo store data, it's a single currency but formatted in different locale. Perhaps you should revert #47 and/or remove all locale formatting of prices altogether to remove confusion if you do not wish to support it (now).

persi123 pushed a commit to persi123/commerce that referenced this issue Oct 21, 2021
Wkasel pushed a commit to DSCO-Co/poochie that referenced this issue Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants