Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add starter settings for Jest #83

Closed
marceloF5 opened this issue Nov 9, 2020 · 2 comments
Closed

Add starter settings for Jest #83

marceloF5 opened this issue Nov 9, 2020 · 2 comments
Labels
checking

Comments

@marceloF5
Copy link
Contributor

marceloF5 commented Nov 9, 2020 •
edited

Hey guys, I saw that this project doesn't have any unit tests. So I'd like to contribute to the unit test and I created this PR #82 in order to apply the starter settings with jest and react testing library.
@marceloF5 marceloF5 mentioned this issue Nov 9, 2020
Closed
@marceloF5 marceloF5 changed the title Add Initial Starter for Jest and RTL Add starter settings for Jest Nov 10, 2020
@okbel okbel added the checking label Nov 26, 2020
@okbel
Copy link
Contributor

okbel commented Nov 26, 2020

Thank you!!! Checking

@lfades
Copy link
Member

lfades commented Jul 30, 2021 •
edited

Although we like the idea of unit testing, it doesn't have enough value for us at the moment, in the future we might start exploring different testing strategies, but for the moment we are not thinking about doing unit testing.

@lfades lfades closed this as completed Jul 30, 2021
persi123 pushed a commit to persi123/commerce that referenced this issue Oct 21, 2021
@robbieaverill
Merge pull request vercel#83 from chec/dependabot/npm_and_yarn/lodash…
3e77f1f 
…-4.17.19

Bump lodash from 4.17.15 to 4.17.19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
checking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@okbel @lfades @marceloF5