Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add starter settings for unit tests - jest #82

Closed
wants to merge 1 commit into from

Conversation

marceloF5
Copy link
Contributor

@marceloF5 marceloF5 commented Nov 9, 2020

Hey people,

This PR is regarding starter settings for unit tests with jest and react testing library.
From this PR, we have the mission of implementing unit tests in each component developed before. We have a lot of work ahead of us 🚀

Totally open to hearing your opinion.

Issue. #83

@vercel
Copy link

vercel bot commented Nov 9, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/commerce/52eo0yoc1
✅ Preview: https://commerce-git-fork-marcelof5-feat-jest.vercel.vercel.app

@rezakalfane
Copy link

Hi!

That's a great idea that will help going towards a professional project.
Was also wondering if it would be easy to use Storybook with this project, any idea? Would reinforce UI dev, unit test UI, do visual tests, etc.

Thanks!

@marceloF5
Copy link
Contributor Author

Hi!

That's a great idea that will help going towards a professional project.
Was also wondering if it would be easy to use Storybook with this project, any idea? Would reinforce UI dev, unit test UI, do visual tests, etc.

Thanks!

Great idea. Storybook is always welcome. I'd say to open an issue with your suggestion and ask for maintainers their opinion too.

@marceloF5 marceloF5 changed the title WIP: feat: Add jest and RTL in order to start with unit tests WIP: feat: Add starter settings for unit tests - jest Nov 10, 2020
@marceloF5 marceloF5 changed the title WIP: feat: Add starter settings for unit tests - jest Add starter settings for unit tests - jest Nov 10, 2020
@marceloF5 marceloF5 marked this pull request as ready for review November 10, 2020 19:48
@okbel okbel self-requested a review December 21, 2020 17:26
@lfades
Copy link
Member

lfades commented Jul 30, 2021

@marceloF5 Hi there, thank you for the PR and sorry for the late review!

From my comment in the issue: #83 (comment)

Although we like the idea of unit testing, it doesn't enough value for us at the moment, in the future we might start exploring different testing strategies, but for the moment we are not thinking about doing unit testing.

@lfades lfades closed this Jul 30, 2021
persi123 pushed a commit to persi123/commerce that referenced this pull request Oct 21, 2021
…-seed-data

Optimize images and updated assets seed data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants