fix(cookies): cookie header format #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
konomae
commented
Mar 21, 2024
•
konomae
commented
- Spec
- It seems incorrect to have a trailing semicolon.
🦋 Changeset detectedLatest commit: 3ac69e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@konomae is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
konomae
commented
Mar 21, 2024
| const headers = new Headers() | ||
| const cookies = new RequestCookies(headers) | ||
| cookies.set('a', '1') | ||
| expect(headers.get('cookie')).toBe('a=1') |
konomae
commented
Mar 21, 2024
| const cookies = new RequestCookies(headers) | ||
| cookies.set('a', '1') | ||
| cookies.set('b', '2') | ||
| expect(headers.get('cookie')).toBe('a=1; b=2') |
There was a problem hiding this comment.
This was a=1; ; b=2;.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Kikobeats
force-pushed
the
fix-cookie-header-format
branch
from
e345c7b
to
861595e
Compare
Kikobeats
force-pushed
the
fix-cookie-header-format
branch
from
861595e
to
3ac69e4
Compare
|
awesome, thanks for this! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.