Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Wrong header in https://app-dir-i18n.vercel.app/ #838

Closed
flixlix opened this issue Dec 10, 2023 · 1 comment · Fixed by #839
Closed

Bug: Wrong header in https://app-dir-i18n.vercel.app/ #838

flixlix opened this issue Dec 10, 2023 · 1 comment · Fixed by #839

Comments

@flixlix
Copy link
Contributor

flixlix commented Dec 10, 2023

image

I noticed the header in the i18n example is incorrect and the Clone & Deploy button leads to the wrong repo.
I searched to the source code to see if I could fix it, but the Nav component seems to be internal:

examples/app-directory/i18n/app/layout.tsx

Line 1 in c70b488

import Nav from '@vercel/examples-ui/nav'

@flixlix flixlix mentioned this issue Dec 10, 2023
Merged
6 tasks
@flixlix
Copy link
Contributor Author

flixlix commented Dec 10, 2023

Found the bug, created a PR fixing it

leerob pushed a commit that referenced this issue Dec 10, 2023
@flixlix
fix: 🐛 incorrect path in 18n example app-dir (#839)
3c5d318 
### Description

<!--
✍️ Write a short summary of your work. Screenshots and videos are
welcome!
-->

Fixes #838. 
Incorrect path in i18n example.
Changed to the correct dir.

### Demo URL

<!--
Provide a URL to a live deployment where we can test your PR. If a demo
isn't possible feel free to omit this section.
-->
https://vercel-examples-orpin.vercel.app/en

### Type of Change

- [ ] New Example
- [x] Example updates (Bug fixes, new features, etc.)
- [ ] Other (changes to the codebase, but not to examples)

### New Example Checklist

- [ ] 🛫 `npm run new-example` was used to create the example
- [ ] 📚 The template wasn't used but I carefuly read the [Adding a new
example](https://github.com/vercel/examples#adding-a-new-example) steps
and implemented them in the example
- [ ] 📱 Is it responsive? Are mobile and tablets considered?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🐛 incorrect path in 18n example app-dir flixlix/vercel-examples
1 participant
@flixlix