Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microfrontends example: Added missing package versions for the apps #363

Closed
wants to merge 2 commits into from

Conversation

kkomelin
Copy link

Description

Providing a fix for #362

Type of Change

  • New Example
  • Example updates (Bug fixes, new features, etc.)
  • Other (changes to the codebase, but not to examples)

@vercel
Copy link

vercel bot commented Jul 18, 2022

@kkomelin is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jul 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
solutions-microfrontends ✅ Ready (Inspect) Visit Preview Jul 18, 2022 at 8:09PM (UTC)
solutions-microfrontends-docs ✅ Ready (Inspect) Visit Preview Jul 18, 2022 at 8:09PM (UTC)
16 Ignored Deployments
Name Status Preview Updated
edge-functions-authed-proxy ⬜️ Ignored (Inspect) Jul 18, 2022 at 8:09PM (UTC)
edge-functions-cookies ⬜️ Ignored (Inspect) Jul 18, 2022 at 8:09PM (UTC)
edge-functions-news ⬜️ Ignored (Inspect) Jul 18, 2022 at 8:09PM (UTC)
edge-maintenance-page ⬜️ Ignored (Inspect) Jul 18, 2022 at 8:09PM (UTC)
edge-user-agent-based-rendering ⬜️ Ignored (Inspect) Jul 18, 2022 at 8:09PM (UTC)
example-auth-with-ory ⬜️ Ignored (Inspect) Jul 18, 2022 at 8:09PM (UTC)
example-reduce-image-bandwidth-usage ⬜️ Ignored (Inspect) Jul 18, 2022 at 8:09PM (UTC)
i18n ⬜️ Ignored (Inspect) Jul 18, 2022 at 8:09PM (UTC)
solutions-combining-data-fetching-strategies ⬜️ Ignored (Inspect) Jul 18, 2022 at 8:09PM (UTC)
solutions-image-fallback ⬜️ Ignored (Inspect) Jul 18, 2022 at 8:09PM (UTC)
solutions-image-offset ⬜️ Ignored (Inspect) Jul 18, 2022 at 8:09PM (UTC)
solutions-loading-web-fonts ⬜️ Ignored (Inspect) Jul 18, 2022 at 8:09PM (UTC)
solutions-pagination-with-ssg ⬜️ Ignored (Inspect) Jul 18, 2022 at 8:09PM (UTC)
solutions-reuse-responses ⬜️ Ignored (Inspect) Jul 18, 2022 at 8:09PM (UTC)
solutions-script-component-ad ⬜️ Ignored (Inspect) Jul 18, 2022 at 8:09PM (UTC)
solutions-script-component-strategies ⬜️ Ignored (Inspect) Jul 18, 2022 at 8:09PM (UTC)

@lfades
Copy link
Member

lfades commented Aug 18, 2022

Hi @kkomelin can you check if the merged changes in #357 fixed the issue you're experiencing with the example? lmk if it worked!

@kkomelin
Copy link
Author

Hi @lfades
Thanks for checking. Unfortunately, your changes didn't help.
I provided a fix in this current PR. Why can't we apply it?

@lfades
Copy link
Member

lfades commented Jan 24, 2023

Closing as per #362 (comment)

@lfades lfades closed this Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants