Refactor/cleanup #172
Refactor/cleanup #172
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/hyper-site/q7ss2b8ul |
refactor header
fix random padding on ios safari, toggle now flips
📝Changed routes:
And 2 other routes: 4 deleted routes:
Commit 63b1aaf (https://hyper-site-git-fork-vassbence-master.vercel.now.sh). |
![Screenshot of /store/[name]](https://images.weserv.nl?url=https://s.microlink.io/guIWKsDaGvWdggkw1J_I_N5_TDA_.png&w=600)
![Screenshot of /store/[name]/source](https://images.weserv.nl?url=https://s.microlink.io/75K9j7Xy7X4BtqTHECKCLespDV4_.png&w=600)
| "husky": { | ||
| "hooks": { | ||
| "pre-commit": "lint-staged" | ||
| } | ||
| }, | ||
| "lint-staged": { | ||
| "*.js": [ | ||
| "prettier --write", | ||
| "git add" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
What's the reason to remove this?
There was a problem hiding this comment.
Husky did not work with [id] named pages, it was a known bug, I can re add it in a sec, if they have since fixed it.
There was a problem hiding this comment.
Here's a config you can use:
// lint-staged.config.js
const escape = require('shell-quote').quote
module.exports = {
'**/*.{js,ts,tsx}': filenames => {
const escapedFileNames = filenames
.map(filename => `"${escape([filename])}"`)
.join(' ')
return [
`eslint --max-warnings 0 ${filenames.join(' ')}`,
`prettier --write ${escapedFileNames}`,
`git add ${escapedFileNames}`
]
}
}
pages/store/[name]/source.js
Outdated
|
|
||
| const formatFileName = (path) => path.replace(/^\/+|\/+$/g, '') | ||
|
|
||
| export default () => { |
There was a problem hiding this comment.
Can you add SSG to this page too 🙏
The source code won't change that much for plugins, and you can add unstable_revalidate to SSG, the page will be revalidated in the background after X seconds
Feature/ssg plugin source
This will fix #171.