Weird behaviour when opening config on Windows

[Stanzilla]

• I am on the latest Hyper.app version
• I have searched the issues of this repo and believe that this is not a duplicate

• OS version and name: Windows 8.1
• Hyper.app version: 1.2.1
• Link of a Gist with the contents of your .hyper.js: https://gist.github.com/Stanzilla/e776f86ed2b919fdfd7a2fc3d9d6de49
• Relevant information from devtools (CMD+ALT+I on Mac OS, CTRL+SHIFT+I elsewhere):
• The issue is reproducible in vanilla Hyper.app:

Issue

When opening the config, a new tab is opened and gets a lot of echos, is this the correct behaviour? From the text it is looking like it's failing a few times but notepad is actually opened.

Should opening the config even spawn a new tab at all?

[stefanivic]

@Stanzilla you are opening the config using the Bash, that's why it only echoes the text as start notepad is not a valid bash command. Your best option is to manually go to c:\Users\yourUser\.hyper.js and edit it.

[jonathanrdelgado]

Looks like #1510 reverted the previous windows fix for this.

[stefanivic]

@jonathandelgado it wasn't really a fix, it just opened the directory instead of directly opening the editor. I am trying to find a better fix as we speak.

[Stanzilla]

@stefanivic it does that with cmd as well

[Stanzilla]

Can the process of trying to open it be done in background though? Also the echo, currently looks like a debug print left there by accident, if you ask me :D

[stefanivic]

@Stanzilla We got this merged : 36f96ab So now, it will check which shell you are runing and open with coresponding option. The echo is there just to notify you what is going on, but i will look into it, how we can make it nicer...

[MartyGentillon]

Related: #901

[MartyGentillon]

Of course, that doesn't work with powershell, which has a different syntax for environment variables ($Env:variableName).

Also, notepad?? it can't make sense of Unix style line endings, which is the default for the preferences file. It might make sense to look that up from the configuration (or environment)

[albinekb]

@MartyGentillon the line-ending issue was fixed with #1713

[Stanzilla]

My main gripe with this was the echo anyway, so if we could make the settings open without any echo or new tab spawning, that would be great

[albinekb]

Yes I think that would be better, use something like https://github.com/sindresorhus/opn ?

[stefanivic]

I don't think we really need any addition library to solve this, you can remove the echo frome the code and still have it working. But to be honest i think the best option would be to replace the echo and have a notification pop up.

[chabou]

I think opn is a good solution. With this, editing config directly uses an OS feature and do not depend on a shell/term feature.

[MartyGentillon]

@albinekb The line endings are only one of very many reasons to dislike the choice of notepad when other editors are available. Roughly speaking, the editor should be controllable either though the editor environment variable or configuration.

As for using a library rather than the shell, vastly simplifies the logic and error proofs the solution. Suddenly there is no need for a "which shell are you running" guessing game to decide how to include the environment variable.

[MartyGentillon]

Alternately, Gordon's solution is interesting:

#1736

[chabou]

Another reason to launch editor with node/lib: #417

[MartyGentillon]

One other advantage of the library approach: it works even when you have sshed into another machine.

[Stanzilla]

Is this even remotely correct? It works fine on WIndows Stanzilla@12ffb17

(first timer here)

[chabou]

Ok guys, I found a solution: https://github.com/electron/electron/blob/master/docs/api/shell.md#shellopenitemfullpath

We don't need a lib, Electron will do it for us :)
Thank you @Stanzilla for your PR, it helps me to think about it.

[chabou]

Another reason to launch native editor: https://zeit-community.slack.com/archives/C1TMVKPFH/p1493735061557196
Some people doesn't know how to save.

[MartyGentillon]

Not to mention that not all systems come with nano....