Simplify and correct newlines replacement logic on Windows #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah sweet! I saw this error when testing hyper on windows, tested this and can confirm it's working 🎉 ping @stefanivic
|
albinekb
approved these changes
Apr 4, 2017
|
Tested by @stefanivic too, works 👌 |
|
Thanks @kvakulo 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New lines in the
.hyper.jsconfig file are not replaced correctly on Windows.There's an error in the replacement logic:
x => x.indexOf('\r') < 0 ? x : '${x}\r'. The test should actually bex.indexOf('\r') >= 0.However, I've simplyfied the replacement logic to make it more clear what happens.
Should be ready to merge!