Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Can't change cursor #2248

Closed
2 tasks done
moso opened this issue Sep 21, 2017 · 8 comments · Fixed by #2437
Closed
2 tasks done

[v2] Can't change cursor #2248

moso opened this issue Sep 21, 2017 · 8 comments · Fixed by #2437
Labels
🐛 Type: Bug Issue pertains to something wrong within Hyper v2

Comments

@moso
Copy link

moso commented Sep 21, 2017

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: Ubuntu Mate 16.04.3
  • Hyper.app version: 2.0.2
  • Link of a Gist with the contents of your .hyper.js: Link
  • Relevant information from devtools: Two plugins get a warning about cursor-node is a deprecated CSS class. But as this is reproducable without plugins, I guess it's irrelevant
  • The issue is reproducible in vanilla Hyper.app: Yes

Issue

Even though it's stated with caps in my hyper.js config that I want BEAM as cursor, I still get the default block.

Also related: cursorBlink: 'true' doesn't work either. Want me to submit a separate issue?

@albinekb albinekb added 🐛 Type: Bug Issue pertains to something wrong within Hyper v2 labels Sep 21, 2017
@PerStirpes
Copy link
Contributor

Same issue different platform

  • Hyper App 2.0.3 (canary)
  • OS ARCH VERSION: darwin, x64, 16.7.0
  • Electron: 1.7.6 LANG: en_US.UTF-8
  • SHELL: /bin/bash
~/.hyper.js contents
        
          {
  "fontSize": 14,
  "updateChannel": "canary",
  "fontFamily": "Menlo, \"DejaVu Sans Mono\", Consolas, \"Lucida Console\", monospace",
  "cursorColor": "rgba(248,28,229,0.8)",
  "cursorShape": "BEAM",
  "cursorBlink": true,
  "foregroundColor": "#fff",
  "backgroundColor": "#000",
  "borderColor": "#333",
  "css": "",
  "termCSS": "",
  "showHamburgerMenu": "",
  "showWindowControls": "",
  "padding": "12px 14px",
  "colors": {
    "black": "#000000",
    "red": "#ff0000",
    "green": "#33ff00",
    "yellow": "#ffff00",
    "blue": "#0066ff",
    "magenta": "#cc00ff",
    "cyan": "#00ffff",
    "white": "#d0d0d0",
    "lightBlack": "#808080",
    "lightRed": "#ff0000",
    "lightGreen": "#33ff00",
    "lightYellow": "#ffff00",
    "lightBlue": "#0066ff",
    "lightMagenta": "#cc00ff",
    "lightCyan": "#00ffff",
    "lightWhite": "#ffffff"
  },
  "shell": "",
  "shellArgs": [
    "--login"
  ],
  "env": {},
  "bell": "SOUND",
  "copyOnSelect": false
}
      {

"plugins": [
"hyperlinks"
],
"localPlugins": []
}

@markozxuu
Copy link

@PerStirpes @moso This is definitely a bug in version 2.0.3

If you want to use BEAM I recommend to go back to the stable version.

@moso
Copy link
Author

moso commented Sep 26, 2017

@mapeso Yeah, I'm staying on 1.4.7 for the time being.

@albinekb albinekb mentioned this issue Sep 26, 2017
8 tasks
@markozxuu
Copy link

markozxuu commented Sep 27, 2017

@albinekb "BEAM" works well mac, windows and linux (check in 3). The only problem is that it has to be in the stable version (1.4.8)

we can rule out that it is an issue related to the operating system 😄

@DDoSolitary
Copy link

DDoSolitary commented Oct 10, 2017

Same here with Hyper v2.0.4 on Arch Linux.
But cursorBlink works for me. @moso Try using true instead of 'true'.

@zfwf
Copy link
Contributor

zfwf commented Oct 10, 2017

If you use the ZSH shell, a workaround is to use the ZSH line editor, then you can have whatever cursor you want. It is pretty easy to setup a blinking i-beam. Below at the bottom of your .zshrc would work.

# zle config
bindkey -v # vi mode
export KEYTIMEOUT=1 # mode change timeout = 0.1sec
function zle-keymap-select zle-line-init
{
	# change cursor shape in xterm
	case $KEYMAP in
		vicmd)      echo -e -n "\x1b[\x32 q";;  # block cursor
		viins|main) echo -e -n "\x1b[\x35 q";;  # blinking line cursor
	esac

	zle reset-prompt
	zle -R
}

zle -N zle-line-init
zle -N zle-keymap-select

@zfwf
Copy link
Contributor

zfwf commented Oct 24, 2017

Just had some time to dig in. In the code term.js line 43, xterm module (version 2.9.2) does not accept cursorStyle parameter which is the cursor style being set. This means the cursor style from ~/.hyper.js is not being used. Is this an API mismatch that can be resolved once upgraded to xterm.js v3? If so, suggest deferring this issue.

@tjallingt
Copy link

I just encountered this with hyper v2 as wel; i cannot change the cursor type to anything but the default block style cursor.

chabou added a commit to chabou/hyper that referenced this issue Nov 6, 2017
chabou added a commit that referenced this issue Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Type: Bug Issue pertains to something wrong within Hyper v2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants