Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinPTY agent fails to launch on Windows 7 #2832

Closed
2 tasks done
codehearts opened this issue Apr 16, 2018 · 27 comments
Closed
2 tasks done

WinPTY agent fails to launch on Windows 7 #2832

codehearts opened this issue Apr 16, 2018 · 27 comments
Labels
help wanted Contributions wanted towards the issue 🖼 Platform: Windows Issue pertains to Windows ❣️ Priority: High Issue is of High priority 🐛 Type: Bug Issue pertains to something wrong within Hyper

Comments

@codehearts
Copy link

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate

Issue

Since updating to 2.0.0 Hyper throws an error at startup. When I hit OK on the popup, the window appears but there's no text entry since there's no terminal. I've done this using cygwin bash and powershell as my shell, neither works.

Uncaught exception:
Error: Error launching WinPTY agent: ConnectNamedPipe failed: Windows error 232
    at new WindowsPtyAgent
...

The call stack seems to be WindowsPtyAgent<-WindowsTerminal<-spawn<-Session<-initSession<-Server.Window.rpc.on.options<-emitOne<-Server.emit<-Server.ipcListener<-emitTwo. This was working on earlier canaries, I see something changed with winpty so I suspect that's what did it.

@chabou
Copy link
Collaborator

chabou commented Apr 16, 2018

Do you remember the last canary that works?

@chabou chabou added the 👀 Awaiting Response Issue or PR is awaiting a response from the author label Apr 16, 2018
@codehearts
Copy link
Author

codehearts commented Apr 16, 2018

I think it was canary 8 or 9 for me. I haven't tried any of the other canary builds

@chabou chabou added help wanted Contributions wanted towards the issue 🖼 Platform: Windows Issue pertains to Windows and removed 👀 Awaiting Response Issue or PR is awaiting a response from the author labels Apr 16, 2018
@codehearts
Copy link
Author

I just verified that canary 8 works for me, but canary 9 throws an unrelated error before throwing the one I've reported here

@corydeppen
Copy link

Just ran into this on Win10 using the new v2.

@chabou chabou added the 🐛 Type: Bug Issue pertains to something wrong within Hyper label Apr 19, 2018
@chabou
Copy link
Collaborator

chabou commented Apr 19, 2018

@corydeppen Is it reproducible each time?

@corydeppen
Copy link

Yes, it hasn't launched without error yet. I've included the full error and link to my .hyper.js file. I'm also wondering if it may be related to #2865.

Error: Error launching WinPTY agent: Security check failed: pipe client pid (6944) does not match agent pid (283536)
    at new WindowsPtyAgent (C:\Users\[username]\AppData\Local\hyper\app-2.0.0\resources\app.asar\node_modules\node-pty\lib\windowsPtyAgent.js:25:24)
    at new WindowsTerminal (C:\Users\[username]\AppData\Local\hyper\app-2.0.0\resources\app.asar\node_modules\node-pty\lib\windowsTerminal.js:45:24)
    at spawn (C:\Users\[username]\AppData\Local\hyper\app-2.0.0\resources\app.asar\node_modules\node-pty\lib\index.js:27:12)
    at Session (C:\Users\[username]\AppData\Local\hyper\app-2.0.0\resources\app.asar\session.js:53:18)
    at initSession (C:\Users\[username]\AppData\Local\hyper\app-2.0.0\resources\app.asar\ui\window.js:102:24)
    at Server.Window.rpc.on.options (C:\Users\[username]\AppData\Local\hyper\app-2.0.0\resources\app.asar\ui\window.js:105:7)
    at emitOne (events.js:115:13)
    at Server.emit (events.js:210:7)
    at Server.ipcListener (C:\Users\[username]\AppData\Local\hyper\app-2.0.0\resources\app.asar\rpc.js:33:11)
    at emitTwo (events.js:125:13)

https://gist.github.com/corydeppen/65735150ddc5e869b84555ce4d7548b8

@UniqueUsr
Copy link

I'm running into the exact same problem as Cory on win10x64 1709. I can re-install 1.48 and work fine for a day but as soon as it upgrades to 2.0.0 it breaks. No plugins installed. Installing clean from 2.0.0 also results in the same error.

@DavidRHulme
Copy link

I've just experienced this issue on Windows 10 when installing Hyper for the first time.

@chabou chabou added the ❣️ Priority: High Issue is of High priority label Apr 23, 2018
@codehearts
Copy link
Author

So this is odd, but I tried 2.0.0 stable yesterday and this error was no longer an issue. Then it came back after rebooting today, and of course I'm clueless as to what I did that could've caused it.

@idike
Copy link

idike commented Jul 6, 2018

javascripterror_hyper

Windows 10 version 1709

@kenorb
Copy link

kenorb commented Jul 26, 2018

Same here on Windows 10,

Normally Hyper terminal works, but it breaks with above error when you run it as Administrator.

image

Hyper 2.1.0.1138 on Windows 10 Pro.


Although after using it more often, the error happens at random when launching as a regular user. It's very annoying.

@boydjeff
Copy link

I'm seeing this error after the upgrade to Hyper 2.1. I did not see the error in version 2.0. I'm in a corporate environment, and think the issue is related to running McAfee Endpoint Security, as described in the reference @octachrome provided above.

If I uninstall Hyper2.1 and reinstall 2.0, then the error goes away, but then Hyper automatically upgrade to 2.1. Is there a way to prevent Hyper from automatically upgrading?

@ljismail0
Copy link

ljismail0 commented Dec 17, 2018

Experiencing the exact same behavior as @boydjeff. Anything we can do? I have tried running as admin with no luck.

System info:
Windows 10.0.15063 Build 15063
McAfee Endpoint Security 10.5.4.4270

image

@talentwill
Copy link

I'm seeing this error after the upgrade to Hyper 2.1. I did not see the error in version 2.0. I'm in a corporate environment, and think the issue is related to running McAfee Endpoint Security, as described in the reference @octachrome provided above.

If I uninstall Hyper2.1 and reinstall 2.0, then the error goes away, but then Hyper automatically upgrade to 2.1. Is there a way to prevent Hyper from automatically upgrading?

Yes, I also met this issue. the issue goes away after I roll back it to 2.1-cannary2. But it always prompt to upgrade. and there is not option that can close auto upgrade!

@parktheredcar
Copy link
Contributor

What about setting releases.hyper.is or releases-canary.hyper.is to 127.0.0.1 in your hosts file to work around the updater?

@aescasio
Copy link

The culprit is in McAfee Real-Time Scanning, I tried turning it off and this error never happens, but when turning back on again the error happens again.

@Ouch
Copy link

Ouch commented Dec 23, 2018

Can confirm @aescasiodev 's find. When turning it off, error no longer happens.

@rnagatama
Copy link

For McAfee issue, I got it working by excluding C:\Users\<User>\AppData\Local\hyper\app-2.1.0\resources\app.asar.unpacked\node_modules\node-pty\build\Release\winpty-agent.exe from real-time scanning on McAfee

@aescasio
Copy link

@rnagatama yes, you need to exclude that file from Real-Time Scanning in any Antivirus.
That works.

@smaccombie smaccombie mentioned this issue Dec 26, 2018
2 tasks
@KingNoosh
Copy link

I've also started running into this in 2.1, I'm unable to change my McAfee's settings in my environment, is there an ETA on the fix?

Could it be perhaps due to the executable not being signed?

@nickhall
Copy link

nickhall commented Jan 7, 2019

Same issue here. Error'd and couldn't start. Excluding the file from real-time scanning did the trick. Thank you guys for the fix!

@talentwill
Copy link

Do you remember the last canary that works?

hyper-Setup-2.1.0-canary.2 is OK.

@marawanshalaby
Copy link

marawanshalaby commented Jan 9, 2019

For McAfee issue, I got it working by excluding C:\Users\<User>\AppData\Local\hyper\app-2.1.0\resources\app.asar.unpacked\node_modules\node-pty\build\Release\winpty-agent.exe from real-time scanning on McAfee

Better to just add **\winpty-agent.exe to your Mcafee exceptions list, so you don't get that same error when hyper auto-updates and changes the app-2.1.0 folder

@ghost
Copy link

ghost commented Jan 18, 2019

Thanks @rnagatama, it works!

@sieberp
Copy link

sieberp commented Jan 22, 2019

Had the same problem and as @rnagatama suggested to add winpty-agent.exe to the McAfee exceptions worked for me. thanks!

@boydjeff
Copy link

Well, Hyper now works in my corporate environment with version 2.1.1. I don't have permissions to add exceptions to McAfee Endpoint Security, so I don't know if an exception was added company-wide or if version 2.1.1 somehow just works. Thanks everyone who saw the same behavior and also commented.

@SteaceP
Copy link

SteaceP commented Feb 18, 2019

The culprit is in McAfee Real-Time Scanning, I tried turning it off and this error never happens, but when turning back on again the error happens again.

Deactivated the McAfee Real-Time Scanning and it worked... Put back the R.T.S. and tried to put some files in the exception list and it didn't work... it just appends to work a bit later... weird!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Contributions wanted towards the issue 🖼 Platform: Windows Issue pertains to Windows ❣️ Priority: High Issue is of High priority 🐛 Type: Bug Issue pertains to something wrong within Hyper
Projects
None yet
Development

No branches or pull requests