Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching to NSIS #2972

Closed
Stanzilla opened this issue May 4, 2018 · 1 comment
Closed

Consider switching to NSIS #2972

Stanzilla opened this issue May 4, 2018 · 1 comment
Labels
💬 Feedback Wanted Issue or PR needs input from the community! Lend your thoughts ✨ 🖼 Platform: Windows Issue pertains to Windows 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper

Comments

@Stanzilla
Copy link
Collaborator

I will use this issue to track what would be needed to transition our Windows installer from using Squirrel to NSIS.

NSIS is the recommended and most supported target on Windows. It replaced Squirrel as the default target a while ago. Squirrel.Windows usage is actually deprecated

See electron-userland/electron-builder#837 which also includes good info on how to handle the transition properly.

It would fix:

It would add the ability to run scripts after the installer is done, which we could use to fix #2823

It would add some features we often denied, like being able to remove user settings after uninstall

@Stanzilla Stanzilla added 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper 💬 Feedback Wanted Issue or PR needs input from the community! Lend your thoughts ✨ 🖼 Platform: Windows Issue pertains to Windows labels May 4, 2018
@LabhanshAgrawal
Copy link
Collaborator

we're using nsis now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💬 Feedback Wanted Issue or PR needs input from the community! Lend your thoughts ✨ 🖼 Platform: Windows Issue pertains to Windows 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper
Projects
None yet
Development

No branches or pull requests

2 participants